Follow-up fix to 14655 #14714
Merged
Follow-up fix to 14655 #14714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/mgmt-format-followup-to-14655
branch
from
1cf286d to
b5e93e5
Compare
lukebakken
force-pushed
the
lukebakken/mgmt-format-followup-to-14655
branch
4 times, most recently
from
4a085ea to
f710de2
Compare
lukebakken
force-pushed
the
lukebakken/mgmt-format-followup-to-14655
branch
2 times, most recently
from
2f7294f to
bbbb0d8
Compare
Follow-up to rabbitmq#14655 The code to format `cacerts` and `certs_keys` needs to check if the incoming value is a list or map, and skip it if not. This is the same pattern as used in a later function head: ``` format_socket_opts([Head = {Name, Value} | Tail], Acc) when is_list(Value) -> ``` It ensures that the code won't be called again on an already-formatted value.
lukebakken
force-pushed
the
lukebakken/mgmt-format-followup-to-14655
branch
from
bbbb0d8 to
275f0a4
Compare
SimonUnge
approved these changes
Oct 11, 2025
michaelklishin
added a commit
that referenced
this pull request
Oct 15, 2025
Follow-up fix to 14655 (backport #14714)
Collaborator
Author
|
Thank you @michaelklishin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14655
The code to format
cacertsandcerts_keysneeds to check if the incoming value is a list or map, and skip it if not. This is the same pattern as used in a later function head:It ensures that the code won't be called again on an already-formatted value.